mreichelt / docker-android

Docker images for Android development
MIT License
74 stars 11 forks source link

Adding Jenkinsfile with delarative pipeline #14

Closed y0nd3rb0y closed 5 years ago

y0nd3rb0y commented 5 years ago

Dear Marc,

I've made it up to the gradlew command in my dockerized Jenkins. Unfortunately gradlew is not a part of Jenkins container so it's not found.

Could you please review the Jenkinsfile and let me know if I can improve anything there or test a build another way?

[Pipeline] stage [Pipeline] { (Build) [Pipeline] sh [android] Running shell script

mreichelt commented 5 years ago

Thanks for the PR! Did you test this on a sample Android project? Every regular Android project comes with a Gradle wrapper script included - so as long as the right Git repo is used this should run fine. Can you try building a sample Android app on your Jenkins? I assume it should build instantly :)

y0nd3rb0y commented 5 years ago

Hi Marc,

Thanks for the hint. I'm new to android development so that was actually my problem. I made it with having checkout of android demo app (https://github.com/meshnesh/android_shared_preferences.git) to the build directory. Here you can see the build log. https://pastebin.com/PQG0wUjD

So basically users should do fine with committed Jenkinsfile although they should add it to the project dir and set SCM to point their project (but that's how it should be from the beginning)

Please let me know if there is sense to add any comments to the Jenkins file. It seems to me that anyone who has to deal with pipeline in Jenkins will find it simple enough to not make any potential caveats.

Thank you for the hint about wrapper :+1:

mreichelt commented 5 years ago

Thanks a lot! 🎉