search

mreineck / ducc

Fork of https://gitlab.mpcdf.mpg.de/mtr/ducc to simplify external contributions
GNU General Public License v2.0
13 stars 12 forks source link

Wheel versions #38

Open msyriac opened 1 month ago

msyriac commented 1 month ago

Is there a reason that the glibc version was updated from 2.17 to 2.28 here? https://github.com/mreineck/ducc/blob/2f969ac5b46f1914074d535899021fbe8eb60252/.github/workflows/wheels_64bit_linux.yml#L23

This makes wheels unavailable on systems using glibc 2.17, forcing one to compile from source.

mreineck commented 1 month ago

It's mostly the desire to have newer compilers (gcc 12 vs gcc 10) available, which have fewer bugs and can deliver better code. Also I plan to switch to C++20 at some point, which will require recent compilers. And since glibc 2.28 was released six years ago, I hoped to e on the safe side ... Also please note that I strongly recommend compiling from source anyway, since that will typically give you a packages that runs twice as fast in many circumstances. The prebuilt wheels only assume SSE2 instructions to be present; when compiling from source, everything up to AVX512 will be used.

msyriac commented 1 month ago

Ok, good, I guess this is a question for my HPC admins, why they're running glibc from 6 years ago..

mreineck commented 1 month ago

Well, on HPC this is probably not so uncommon, if the basic OS is not replaced during the lifetime of the machine. Still, on this kind of machine, using a custom-compiled package is even more important :-)

msyriac commented 1 month ago

Agreed!