Closed LeeoBianchi closed 1 year ago
Regarding the *start
arrays, to me it looks like the smoother solution is to switch to the 1-base convention on the Julia side and implement the conversion to the 0-base in the wrapper file ducc_julia.cc
. If we want to keep everything on a 0-base, the offset
name solution sounds good tho.
Yes, at that line the code still segfaults. I'm emailing you now a fairly commented example.
Thank you very much.
Merging now, work will most likely continue in another dedicated repository.
Thanks a lot for this!
What's your opinion on the
*start
arrays? Should we honour Julia's 1-based convention and expect 1-based indices here? Or should we perhaps rename*start
to*offset
, where zero-based numbers would feel more natural again?You mention at one point in the sources that the code segfaults; is this still the case? If so, I can have a closer look if you could provide me with a small example.