search

mreineck / ducc

Fork of https://gitlab.mpcdf.mpg.de/mtr/ducc to simplify external contributions
GNU General Public License v2.0
13 stars 12 forks source link

switch to one-based wrapper; hide unnecessary symbols in shared library #5

Closed mreineck closed 1 year ago

mreineck commented 1 year ago

@LeeoBianchi I had an idea how we can implement the base-1 to base-0 changes on the C++ side easily after all. Does this look OK to you? Sorry for changingmy mind so often, but I think this is now pretty consistent, since all adjustments happen in one place,i.e. ducc_julia.cc.

LeeoBianchi commented 1 year ago

@LeeoBianchi I had an idea how we can implement the base-1 to base-0 changes on the C++ side easily after all. Does this look OK to you? Sorry for changingmy mind so often, but I think this is now pretty consistent, since all adjustments happen in one place,i.e. ducc_julia.cc.

It looks very good! I like the fact of having everything on C++ side.

Shouldn't to_vector_subtract_1 be applied to ringstart as well?

mreineck commented 1 year ago

Shouldn't to_vector_subtract_1 be applied to ringstart as well?

Yes, absolutely! Patch incoming...