search

mreineck / pocketfft

Fork of https://gitlab.mpcdf.mpg.de/mtr/pocketfft to simplify external contributions
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

aligned_alloc shim for macOS<10.15 #9

Closed lucascolley closed 10 months ago

lucascolley commented 10 months ago

See scipy/scipy#19811.

Do we need to check whether MAC_OS_X_VERSION_MIN_REQUIRED is defined before doing the comparison? My understanding is that it will evaluate to 0 >= 0 if not on MacOS but correct me if I'm wrong.

mreineck commented 10 months ago

Let's try the change as it is! If some preprocessors are unhappy with it (the scipy CI should uncover that), we can always introduce additional checks.