validate() doesn't check the "Not Before" date

[navzam]

In validate-cert.js, this code

var notAfter = new Date(cert.validity.notAfter)
var remainingDays = notAfter.getTime() - new Date().getTime()
// check that the signing certificate has not expired (examine both the Not
// Before and Not After dates)
if (remainingDays < 1) {
  return 'certificate expiration check failed'
}

checks the "Not After" date, but it doesn't check the "Not Before" date.

[mreinstein]

This is another case of the comment not matching the actual check. I'd be open to either updating the comment, or accepting a PR that adds the "not before" check.

good catch! 👍

[navzam]

I'm in favor for adding a "not before" check, since the Checking the Signature of the Request docs say to check both Not After and Not Before

[mreinstein]

closed via #25