Adding support for http_proxy environment variable to be used for https

mreinstein / alexa-verifier

✓ Verify HTTP requests sent to an Alexa skill are sent from Amazon

MIT License

76 stars 23 forks source link

Adding support for http_proxy environment variable to be used for https #45

Open kyle-wrenn opened 6 years ago

kyle-wrenn commented 6 years ago

@mreinstein Hey Mike, any thoughts on this feature?

mreinstein commented 6 years ago

@kyle-wrenn I have mixed feelings about the feature, but I'm not totally opposed to it either. I'd feel much better about the thing if there were unit tests that exercise this new functionality.

kyle-wrenn commented 6 years ago

@mreinstein I've added a couple of tests to simulate the presence of http_proxy environment variables.

mreinstein commented 6 years ago

@kyle-wrenn would https://www.npmjs.com/package/global-tunnel solve your proxying related problems?