search

mreinstein / alexa-verifier

✓ Verify HTTP requests sent to an Alexa skill are sent from Amazon
MIT License
76 stars 23 forks source link

Tests should mock fetching the public certificate when testing primary functionality #70

Open tejashah88 opened 10 months ago

tejashah88 commented 10 months ago

I've noticed that the tests in test/index.js mostly don't mock fetching the certificate from the URL, which can lead to flaky tests. I recommend adding mocking functionality (similar to how you used nock in test/fetch-cert.js).

mreinstein commented 10 months ago

open to a PR