mreinstein / collision-2d

2d collision routines
MIT License
123 stars 0 forks source link

NPM? #16

Open sc0ttr0berts0n opened 1 month ago

sc0ttr0berts0n commented 1 month ago

I feel bad to say that I bounced off this lib for three reasons: Its perfect in concept, but lacks NPM support as far as I can tell. I started porting it myself but the external dependencies became tedious to also port, and lastly, its not typed anywhere for typescript which would also be helpful.

This is your library and you can 100% run it however you want, but I thought the feedback was warranted if I decided not to use it.

Thank you for your work, this is a well put together library. Just a slight mismatch for me.

mreinstein commented 1 month ago

lacks NPM support as far as I can tell

I'm not opposed to npm support. I haven't published there to iterate rapidly on concepts without worrying about supporting a stable interface (yet). I expect at some point an npm package(s) will arrive. Probably sooner with help. ;)

I started porting it myself but the external dependencies became tedious to also port

Hmm, which external deps were tedious? There really aren't many; most of them are already npm packages, except for a couple tiny functions: https://github.com/mreinstein/collision-2d/blob/main/src/deps.js

its not typed anywhere for typescript

Also not opposed to typescript support, though I really have no interest in it personally whatsoever. I will happily support any autogenerating bits to keep the ts enthusiasts happy though!

This is your library and you can 100% run it however you want, but I thought the feedback was warranted if I decided not to use it.

Thank you for your feedback! I wish you had engaged earlier instead of waiting until feeling burned out or frustrated with this module. We could have probably worked together on these issues. Waiting that long and then giving me a failing grade on my module is a bit de-motivating. :(

Thank you for your work, this is a well put together library. Just a slight mismatch for me.

Thank you for taking time to write, even if it is quite late in the process. If you change your mind and want to tackle any of the above issues, PRs welcome! 💪