search

mreinstein / node-gearman

⚙ Gearman client and worker for node
75 stars 13 forks source link

Porting gearman changes to coffee script #12

Closed goelvivek closed 11 years ago

goelvivek commented 11 years ago

porting earlier change to coffee script

mreinstein commented 11 years ago

@goelvivek don't rename the protocol packet types.

e.g., packet type 31 is listed as JOB_ASSIGN_UNIQ in the spec. I want to maintain 100% parity with the protocol spec: http://gearman.org/protocol

Also, where did the packet numbers above 36 come from? They don't seem to be standard gearman packet types. Are you extending the protocol?

goelvivek commented 11 years ago

On Wed, Jun 26, 2013 at 10:33 PM, Mike Reinstein notifications@github.comwrote:

@goelvivek https://github.com/goelvivek don't rename the protocol packet types.

ya.It was mistake. Sorry I got confused as new commands are end with UNIQUE and old command called as UNIQ. I thought that is mistake in your source code and had modified that.

e.g., packet type 31 is listed as JOB_ASSIGN_UNIQ in the spec. I want to maintain 100% parity with the protocol spec: http://gearman.org/protocol

If you have server code. You can see these commands in file ./libgearman-1.0/protocol.h I have reported about old documentation on protocol on https://bugs.launchpad.net/gearmand/+bug/1194469

Also, where did the packet numbers above 36 come from? They don't seem to be standard gearman packet types. Are you extending the protocol?

— Reply to this email directly or view it on GitHubhttps://github.com/mreinstein/node-gearman/pull/12#issuecomment-20063545 .

goelvivek commented 11 years ago

If , I change UNIQUE again back to UNIQ, will you accept pull request ? Or do you have any other concern ?

regards Vivek Goel

On Wed, Jun 26, 2013 at 10:51 PM, Vivek Goel goelvivek2011@gmail.comwrote:

On Wed, Jun 26, 2013 at 10:33 PM, Mike Reinstein <notifications@github.com

wrote:

@goelvivek https://github.com/goelvivek don't rename the protocol packet types.

ya.It was mistake. Sorry I got confused as new commands are end with UNIQUE and old command called as UNIQ. I thought that is mistake in your source code and had modified that.

e.g., packet type 31 is listed as JOB_ASSIGN_UNIQ in the spec. I want to maintain 100% parity with the protocol spec: http://gearman.org/protocol

If you have server code. You can see these commands in file ./libgearman-1.0/protocol.h I have reported about old documentation on protocol on https://bugs.launchpad.net/gearmand/+bug/1194469

Also, where did the packet numbers above 36 come from? They don't seem to be standard gearman packet types. Are you extending the protocol?

— Reply to this email directly or view it on GitHubhttps://github.com/mreinstein/node-gearman/pull/12#issuecomment-20063545 .

mreinstein commented 11 years ago

I have reported about old documentation on protocol on Nice follow-through!

If , I change UNIQUE again back to UNIQ, will you accept pull request ? Yep!

goelvivek commented 11 years ago

Done. I have reverted back old command to UNIQ.

regards Vivek Goel

I have reported about old documentation on protocol on Nice follow-through!

If , I change UNIQUE again back to UNIQ, will you accept pull request ? Yep!

— Reply to this email directly or view it on GitHubhttps://github.com/mreinstein/node-gearman/pull/12#issuecomment-20066308 .

mreinstein commented 11 years ago

wanna resubmit?