search

mreinstein / node-gearman

⚙ Gearman client and worker for node
75 stars 13 forks source link

Porting changes to gearman.coffee #13

Closed goelvivek closed 11 years ago

mreinstein commented 11 years ago

You've added debug as a dependency but not updated package.json to reflect this. Please do so.

goelvivek commented 11 years ago

Debug is just optional package. If that is installed it will use that module in debug mode without effecting module behaviour. Module will work fine without debug module also. Adding debug module as necessary dependency will not be a good idea. I have seen same behaviour in other node modules, where they have added debug module but not making it as dependency of their module.

regards Vivek Goel

On Sat, Jun 29, 2013 at 12:35 PM, Mike Reinstein notifications@github.comwrote:

You've added debug as a dependency but not updated package.json to reflect this. Please do so.

— Reply to this email directly or view it on GitHubhttps://github.com/mreinstein/node-gearman/pull/13#issuecomment-20225698 .

goelvivek commented 11 years ago

If you still think , I will add it in dependency .

regards Vivek Goel

On Sat, Jun 29, 2013 at 5:08 PM, Vivek Goel goelvivek2011@gmail.com wrote:

Debug is just optional package. If that is installed it will use that module in debug mode without effecting module behaviour. Module will work fine without debug module also. Adding debug module as necessary dependency will not be a good idea. I have seen same behaviour in other node modules, where they have added debug module but not making it as dependency of their module.

regards Vivek Goel

On Sat, Jun 29, 2013 at 12:35 PM, Mike Reinstein <notifications@github.com

wrote:

You've added debug as a dependency but not updated package.json to reflect this. Please do so.

— Reply to this email directly or view it on GitHubhttps://github.com/mreinstein/node-gearman/pull/13#issuecomment-20225698 .

goelvivek commented 11 years ago

Hi, any update about your thought ? Should I add debug module in package list or not ? On 30-Jun-2013 12:38 AM, "Vivek Goel" goelvivek2011@gmail.com wrote:

If you still think , I will add it in dependency .

regards Vivek Goel

On Sat, Jun 29, 2013 at 5:08 PM, Vivek Goel goelvivek2011@gmail.comwrote:

Debug is just optional package. If that is installed it will use that module in debug mode without effecting module behaviour. Module will work fine without debug module also. Adding debug module as necessary dependency will not be a good idea. I have seen same behaviour in other node modules, where they have added debug module but not making it as dependency of their module.

regards Vivek Goel

On Sat, Jun 29, 2013 at 12:35 PM, Mike Reinstein < notifications@github.com> wrote:

You've added debug as a dependency but not updated package.json to reflect this. Please do so.

— Reply to this email directly or view it on GitHubhttps://github.com/mreinstein/node-gearman/pull/13#issuecomment-20225698 .