Upgrade from Beta to Release of Bootstrap 4

bjammin commented 6 years ago

Just a note for when this gets done. Bootstrap 4 beta seems to deprecate use of _custom.scss and it doesn't seem to work in this project as of now (changes to this file have no effect).

So when bootstrap 4 release is added please ensure there is a way of adding custom variable values without modifying the core files.

Reference: https://stackoverflow.com/questions/45651432/bootstrap-4-scss-overrides-not-working

Thanks!

bjammin commented 6 years ago

Also it would be really handy to implement bootstrap-vue as none of the bootstrap javascript components work currently (eg. the nav in mobile mode)

https://bootstrap-vue.js.org/

mrellipse commented 6 years ago

ah, it's now vue-bootstrap@4

I didn't expect bootstrap 4 to be in alpha for so long! so I held off adding bootstrap-vue until v4 was official

you asked about making pull requests before ... would you be willing to contribute one for vue-bootstrap? it's a pretty substantial piece of work to ask for, but github can offer you many fake internet points in return ;)

bjammin commented 6 years ago

I'd certainly be willing, but I'm such a noob with vue and the whole webpack process. I'm not even sure which option to use to get started.

If you could point me in the right direction and give me a few notes I'd be happy to have a go.

mrellipse commented 6 years ago

:+1

no guts no glory.

alrighty, i will do some research and drop you an email! webpack can definitely be intimidating at first - but it's basically just a series of input/output pipes. You configure each step in the chain to filter the data inputs, operate on the selected inputs/files, and then produce one (or many) new outputs.

mrellipse commented 6 years ago

hi again!. just thought I would drop you a quick email to let you know i haven't forgotten about this.

between work, family, kids and commuting, i get a bit time poor.

will try and spend some time on this today - I had a quick look on sunday, and getting bootstrap-vue integrated with webpack shouldn't be too much of an ask!

On Sun, Feb 11, 2018 at 7:41 PM, bjammin notifications@github.com wrote:

I'd certainly be willing, but I'm such a noob with vue and the whole webpack process. I'm not even sure how to get started https://bootstrap-vue.js.org/docs.

If you could point me in the right direction and give me a few notes I'd be happy to have a go.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mrellipse/toucan/issues/18#issuecomment-364734158, or mute the thread https://github.com/notifications/unsubscribe-auth/AF30XY4fvS39vWOFoyAEpdbRYPlEMG5Iks5tTqeggaJpZM4R3-C_ .

mrellipse commented 6 years ago

okay, i have done a review, and the following steps should get things underway

clone the project from development
update the ui project dependencies for popper and bootstrap
add bootstrap-vue to dependencies
install dependencies
add 'bootstrap-vue' to the entry point for vendors bundle (webpack.config.js line 113)
import and register bootstrap-vue
debug!

once above is okay, the real work can get underway. that is, redoing the forms and components to take advantage of model-binding and events exposed by bootstrap-vue.

the bootstrap/sass compilation should be okay - webpack loaders are already configured for dev and production builds - so I am pretty confident that will work 'as is'.

let me know if you have any hassles!

:+1

cheers

On Wed, Feb 14, 2018 at 8:46 AM, Jamie Webb mrellipse@gmail.com wrote:

hi again!. just thought I would drop you a quick email to let you know i haven't forgotten about this.

between work, family, kids and commuting, i get a bit time poor.

will try and spend some time on this today - I had a quick look on sunday, and getting bootstrap-vue integrated with webpack shouldn't be too much of an ask!

On Sun, Feb 11, 2018 at 7:41 PM, bjammin notifications@github.com wrote:

I'd certainly be willing, but I'm such a noob with vue and the whole webpack process. I'm not even sure how to get started https://bootstrap-vue.js.org/docs.

If you could point me in the right direction and give me a few notes I'd be happy to have a go.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mrellipse/toucan/issues/18#issuecomment-364734158, or mute the thread https://github.com/notifications/unsubscribe-auth/AF30XY4fvS39vWOFoyAEpdbRYPlEMG5Iks5tTqeggaJpZM4R3-C_ .

bjammin commented 6 years ago

Thanks very much for looking into this. I'm away from work for the next 1.5 weeks so won't have a chance to look at this until then, but I certainly will!

hmuhdkamran commented 6 years ago

I have done it, and it work flawlessly, I have also integrated Metronic 5, looking nice

mrellipse commented 6 years ago

i have actually been toying with the idea of breaking change - to provide support for a small selection of UI frameworks, when you using the yeoman generator for scaffolding (probably html5 boilerplate, bootstrap, material)

it would be a pretty big piece of work - will see how much energy i have in coming weeks :)

mrellipse commented 6 years ago

superceded by plans for v3 release. no longer current issue.

mrellipse / toucan

Upgrade from Beta to Release of Bootstrap 4 #18