mremi / ContactBundle

Provides a contact form for a Symfony project.
27 stars 23 forks source link

Put classes names in parameters to ease override. #1

Closed mcg-web closed 11 years ago

mremi commented 11 years ago

Hello,

You can configure the form type and the subject provider (and many others), look at the step 4 from the readme, so no need parameters. For the form factory, you can also configure all dependencies.

So you are free to create your own services and then you just need to configure the bundle to use them.

Is it ok for you?

mcg-web commented 11 years ago

Hello @mremi,

Thank for your answer! this true but i think that the solution of the parameters could help beginners overload or override much faster, but no debate this is fact that we can override in creating service.

mremi commented 11 years ago

I prefer this way, moreover it allows you to inject what you want. But I'm ready to merge documentation to explain how to configure some parts.

mcg-web commented 11 years ago

Ok no problem i understand better now. I will try to contribute this part today. Thanks again.