mrempel / geohexviz

GeoHexViz - generating publication-quality geospatical visualization of hexagonally binned data
MIT License
6 stars 2 forks source link

Enable user to install from conda-forge channel #6

Open tony-zeidan opened 1 year ago

tony-zeidan commented 1 year ago

I definitely believe that users should be able to install our package from an anaconda distribution. This goes hand-in-hand with PyPI distribution.

martinfleis commented 1 year ago

See https://github.com/conda-forge/staged-recipes/pull/21956

martinfleis commented 1 year ago

Conda is failing on

ERROR: Package 'geohexviz' requires a different Python: 3.11.0 not in '<=3.8.16,>=3.7'

Why do you have this very restrictive and out-of-date pin in here https://github.com/mrempel/geohexviz/blob/c2c07b39a4dfbe87b6a9b43dc3a9da228a8508cd/setup.py#L26 and https://github.com/mrempel/geohexviz/blob/c2c07b39a4dfbe87b6a9b43dc3a9da228a8508cd/pyproject.toml#L13?

Btw, you should not specify the package metadata in both pyproject and setup.py, using pyproject.toml shall be enough. See this warning emitted during the build

      ##########################################################################
      # configuration would be ignored/result in error due to `pyproject.toml` #
      ##########################################################################

      The following seems to be defined outside of `pyproject.toml`:

      `entry-points = {'console_scripts': ['geohexsimple=geohexviz.simple:main']}`

      According to the spec (see the link below), however, setuptools CANNOT
      consider this value unless 'entry-points' is listed as `dynamic`.

      https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

      For the time being, `setuptools` will still consider the given value (as a
      **transitional** measure), but please note that future releases of setuptools will
      follow strictly the standard.

      To prevent this warning, you can list 'entry-points' under `dynamic` or alternatively
      remove the `[project]` table from your file and rely entirely on other means of
      configuration.
mrempel commented 1 year ago

@martinfleis Regarding the Python version range, I recall that @tony-zeidan and I were running into issues using newer version of Python. I have retested the package using 3.7 through 3.11, and all tests (using pytest) passed and all automated tests passed. I have updated the automated tests to now run for 3.7 through 3.11, and setup.py and environment.yml state that the version of python required is >= 3.7.

These changes have been pushed to the master branch.

mrempel commented 1 year ago

@martinfleis - pyproject and setup.py, using pyproject.toml have been updated as mentioned above. These changes are call captured in the release v1.0.2 and are resident in PyPi as well.

martinfleis commented 1 year ago

It is available now https://github.com/conda-forge/geohexviz-feedstock. Not yet for Arm processors (like M1, M2 MacBooks) but I will schedule a bot to do the migration to that as well.