search

mrengy / vanguard-history

History site for the Santa Clara Vanguard
GNU General Public License v3.0
0 stars 0 forks source link

Add header styles #60

Closed shekharkhedekar closed 1 year ago

shekharkhedekar commented 1 year ago

Adds styles for the mobile header - it looks fine in desktop but needs some responsive love for some specific screen sizes.

Screenshot 2022-12-12 at 5 08 56 PM Screenshot 2022-12-12 at 5 08 52 PM
mrengy commented 1 year ago

Nice! Yeah, looking good. And not too bad on desktop either, I agree. I pulled this branch to dev at https://historyscv-dev.dreamhosters.com/ Only remaining issue I'm seeing is that there's a layer issue on the homepage - the navigation is appearing behind the embedded YouTube video https://jmp.sh/mv9ZheAM . Could you correct that @shekharkhedekar ?

shekharkhedekar commented 1 year ago

@mrengy done, thanks! I caught that but forgot to push the commit.

shekharkhedekar commented 1 year ago

Updated to handle 360px minimum width - and still look ok on larger screen sizes

mrengy commented 1 year ago

All right. I deployed this to stage. Also I renamed the dev and stage sites in WordPress settings so they both just have the site name of "Vanguard History" without the "[dev]" or "[stage]" before it - to make it match what production will do with the site name in that header.

Do you plan to continue to use this branch, or shall I delete it?

shekharkhedekar commented 1 year ago

I’ll delete.

mrengy commented 1 year ago

Thanks!

On Dec 13, 2022, at 6:36 PM, Shekhar Khedekar @.***> wrote:

 I’ll delete.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.