Top Section Progress

[shekharkhedekar]

Progress on styling the top section (title, video, excerpt, story).

Some things I noticed:

• The excerpt is not showing up locally - maybe I need to re-import data?
• Some of the blockquotes in the 2001 story are not blockquoted
• The page is not using MyriadPro (even though the font-family is specified). Do we need to add this via a WP plugin? Or am I not correctly loading this locally?

[mrengy]

Nice!

I pulled this to dev at https://historyscv-dev.dreamhosters.com/year_story/2001-scv/ and it looks right there. I'm not running into any of those issues you called out under some things I noticed

1. So yes, I think you need to re-import data from stage - I just updated the readme on main (and also merged it into this branch) calling out that stage is the source of truth for content. Let me know if you have issues with downloading the export file from the All in 1 WordPress Migration plugin, and I can send you a DB export if needed.
2. Blockquotes seem to all be blockquoted for me - unless I am missing one. If this is still an issue after you re-import data from stage, let me know which ones are affected.
3. Myriad Pro is loading for me, both locally and on dev. Not sure what's going on for you. That's weird.

Separately, I think we should not tile the shield background either horizontally or vertically. Perhaps just fix it in the top-left and have the same color solid red background extend to the rest of the content.

Let me ask Adam in Basecamp if he intends for the red background to extend to the full story or what he intends to do with the background for the full story content.

[shekharkhedekar]

@mrengy Myriad Pro is not a mac system font - for example, if I update the font stack in _var.scss to

// font stack
$MyriadStack: "Myriad Pro", Myriad, "Liberation Sans", "Nimbus Sans L",
    "Helvetica Neue", Georgia;

...I see Georgia as the font. Do you?

Also, when I try to export from stage, I get "Failed - No File" in Chrome. Any chance you can export and post in basecamp or something?

[mrengy]

Weird. I'm not having that issue. I pasted in that code snippet from your earlier comment, and it's loading Myriad Pro for me. I also pulled the most recent updates to this branch to dev, and I'm seeing Myriad Pro loaded there too.

Maybe there was an issue compiling it from SCSS to CSS locally for you? But that wouldn't completely explain it because I committed an updated CSS file in this branch which I think you must have pulled by now, and that's whats on dev as well. If checking the SASS compiling to CSS doesn't resolve it, I'm stumped. Stack overflow? ;)

Let me get you a DB export.

[mrengy]

Okay, I just sent the DB export and instructions in a Basecamp ping.

[shekharkhedekar]

@mrengy Are you on mac or windows?

[mrengy]

Mac.

On Dec 16, 2022, at 9:48 PM, Shekhar Khedekar @.***> wrote:

 @mrengy Are you on mac or windows?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[shekharkhedekar]

@mrengy added styles for repertoire and media. Mind if we merge this and add Adam's feedback in another PR?

[shekharkhedekar]

merry xmas btw

[shekharkhedekar]

I can figure out the myriad issue in another PR too

[mrengy]

I also pulled it to stage.

Merry Christmas to you as well!

[shekharkhedekar]

AFAICT main looks good locally, but stage seems to be on an older version.

[shekharkhedekar]

Oh style.css is outdated. I'll put up a PR.