Closed shekharkhedekar closed 1 year ago
I caught one other thing about distorted profile photos and updated my review comment with that.
Also, I pulled this branch to dev in case you'd like to look at it there.
@mrengy fixed the reply stuff (class name changed) and the avatar size (weird flex box issue)
Thanks! The fixes look good.
I was getting some merge conflicts locally, and I did a reset --hard
which resolved them. I got the same merge conflicts when pulling this branch to dev. I think this is due to the rebase you did, right? Do you think we will be missing any changes if I do the same reset --hard on dev? If it seems safe to do this, I'll let you merge this PR and later I'll update it on dev (I'll be traveling most of the day tomorrow).
Here's some Terminal output from dev.
[disston]$ git pull remote: Enumerating objects: 127, done. remote: Counting objects: 100% (58/58), done. remote: Compressing objects: 100% (21/21), done. remote: Total 127 (delta 37), reused 49 (delta 33), pack-reused 69 Receiving objects: 100% (127/127), 47.51 KiB | 170.00 KiB/s, done. Resolving deltas: 100% (56/56), completed with 10 local objects. From https://github.com/mrengy/vanguard-history
Once I merge to main you should be able to pull on dev/stage. I don't know why you had to reset --hard. I prefer rebasing on main to merging main in to preserve commit history and avoid ugly merge commits. I think you need to approve the PR before I can merge
2 file(s) had their final line ending fixed:
wp-content/themes/vanguard-history/comments.php
,- wp-content/themes/vanguard-history/style.css