search

mreq / slick-lightbox

A lightbox wrapper for Ken's amazing slick carousel.
http://mreq.github.io/slick-lightbox/
MIT License
229 stars 103 forks source link

Still working with new version? #4

Closed ibsenleo closed 9 years ago

ibsenleo commented 9 years ago

Says undefined in the image container

mreq commented 9 years ago

Working like it should, don't see undefined anywhere. Care to post a screenshot?

ibsenleo commented 9 years ago

Sorry, i solve it as i could.

i had to change line 51: return "<div class=\"slick-lightbox-slick-item\"><div class=\"slick-lightbox-slick-item-inner\"><img class=\"slick-lightbox-slick-img\" src=\"" + el.href + "\" />" + caption + "</div></div>";

for this: return "<div class=\"slick-lightbox-slick-item\"><div class=\"slick-lightbox-slick-item-inner\"><img class=\"slick-lightbox-slick-img\" src=\"" + el.src + "\" />" + caption + "</div></div>";

otherwise, the href property returns undefined for me. Thanks for your answer and sorry for change your code for my porpouse.

Grettings Ibsen.

mreq commented 9 years ago

Sounds like you have a different HTML structure than what's proposed in the readme. For that, you either have to change the javascript code or use the images option..

Closing this for now as that's neither an issue nor a constructive idea.