search

mreq / slick-lightbox

A lightbox wrapper for Ken's amazing slick carousel.
http://mreq.github.io/slick-lightbox/
MIT License
229 stars 103 forks source link

Captions are not loading #46

Closed ahbyass closed 7 years ago

ahbyass commented 7 years ago

Captions are not loading using the data-caption option - this can be seen in the demo in repo as it is also not working.

johnbburg commented 7 years ago

If you are looking at the demo preview code, there seems to be an error there. There is no comma after:

caption: 'caption'

But it is in the source. So I'm not sue why it doesn't actually appear in the running demo.

meetWibe commented 7 years ago

Cations not working still, am i missing something? https://codepen.io/meetwibe/pen/MogNYm

hum-n commented 7 years ago

@meetWibe It isn't. My PR https://github.com/mreq/slick-lightbox/pull/50 should fix it

mreq commented 7 years ago

Sorry about that, it was introduced by a PR. Am working on unit tests which will eliminate such cases. Fixed in 0.2.10.