Should laszip4j support Java 8?

mreutegg / laszip4j

The LASzip library ported to Java

GNU Lesser General Public License v2.1

34 stars 15 forks source link

Should laszip4j support Java 8? #90

Closed jandam closed 10 months ago

jandam commented 11 months ago

I would like to ask if laszip4j should support Java 8? It is compiled with class target: Java 8 but with Java >= 9. Problem is with calling: buffer.rewind() in: ByteStreamInDataInput.java ByteStreamOutDataOutput.java ByteStreamOutFile.java

In Java 8 buffer.rewind return Buffer type. For Java >= 9 rewind is redefined in ByteBuffer to return ByteBuffer type. It means that laszip4j can't be run in Java 8 because different method descriptor. Thank you

mreutegg commented 10 months ago

Ah, right. That was a nasty breaking change.

This should be fixed with https://github.com/mreutegg/laszip4j/pull/96

Java 11 is now required to build, but laszip4j should run also on Java 8.