Ben_NOAA_changes

[qq23840]

Added a README.txt for the output zipfile. Not sure whether the code to copy it into the zip directory will actually work. Added AGAGE data availability/usage statements as attributes to the output files, as per NOAA ObsPack Added a json converting standard_name attributes of the mf and mf_repeatability variables to accepted standard_names under CF conventions NOT YET added a test for CF Compliance (Gareth and I to discuss)

[lukewestern]

I would make the ZIPFILE_README.txt file a markdown (.md) file and remove all the hashes on the left side as they serve no purpose. The naming of the file could also be more informative, e.g., agage-data_README.md or something similar. (zipfle isn't obvious)

[lukewestern]

Also, is it worth putting a licence in the README? And/or should it appear as an attribute?

CC BY 4.0 (or maybe even CC BY-SA 4.0) I would imagine

[qq23840]

Made and pushed the changes you mentioned @lukewestern - should be ready to go now I think

[lukewestern]

It says that there are merge conflicts in test_formatting.py then need to be fixed @qq23840. These will need to be fixed before merge.

[qq23840]

Merge conflicts fixed - was just a silly formatting thing. Also committed the changes in your previous comments.

[mrghg]

Thanks for doing this Ben. Please take a look at my latest fix to test_formatting, and note that I don't think the standard_names table was actually being read before?

The CF test still fails for me, because it doesn't seem to like the repeatability variable as having a standard name. Should we prevent these variables from having a standard name (i.e., only have the "mf" variable have a standard name)?

[mrghg]

@qq23840 or @lukewestern , are either of you available to review the latest changes I've made? See commit messages

[qq23840]

I can take a look now