sql support

[GoogleCodeExporter]

hi, I implemented SQL support. Patch attached. a.

Original issue reported on code.google.com by mennu...@debian.org on 28 Mar 2013 at 8:20

Attachments:

• sqlite.diff

[GoogleCodeExporter]

Hi, Good work. Sqlite was really missing as an option in wfrog. 

One question: is it correct that the database parameter (filename) is an 
optional parameter without a default value? I am not familiar to sqlite, but it 
looks like this is a mandatory parameter in the sqlite3.connect method.

I'll add you as a commiter so that, if you prefer, you can commit these changes 
yourself.

Original comment by jordi.pu...@gmail.com on 29 Mar 2013 at 8:16

[GoogleCodeExporter]

Hi, Good work. Sqlite was really missing as an option in wfrog. 

One question: is it correct that the database parameter (filename) is an 
optional parameter without a default value? I am not familiar to sqlite, but it 
looks like this is a mandatory parameter in the sqlite3.connect method.

I'll add you as a commiter so that, if you prefer, you can commit these changes 
yourself.

Original comment by jordi.pu...@gmail.com on 29 Mar 2013 at 8:16

[GoogleCodeExporter]

hi, I don't know YAML well enough; 'filename' is a mandatory parameter. How do 
I make it mandatory?

Original comment by mennu...@debian.org on 29 Mar 2013 at 12:13

[GoogleCodeExporter]

I use 'wfrog' in a "Lacie Network Space" that is a small ARM box that was sold 
as a small NAS, but I hacked Debian into it; it is quite underpowered; it took 
ages to render graphs ; with Sqlite it is much faster.

Original comment by mennu...@debian.org on 29 Mar 2013 at 12:15

[GoogleCodeExporter]

To make it mandatory we do it in the code, either by asserting that the 
parameter is != None or just putting a default value if it is not informed. 
Usually in the storage modules we've used default values with a specific 
standard location or name for the database.

Original comment by jordi.pu...@gmail.com on 29 Mar 2013 at 1:13

[GoogleCodeExporter]

uploaded the code into SVN; please doublecheck it

Original comment by mennu...@debian.org on 31 Mar 2013 at 7:43

• Changed state: Fixed