search

mrgnlabs / marginfi-v2

Apache License 2.0
147 stars 61 forks source link

fix: Remove deprecated Cargo.toml feature flag #155

Closed exdx closed 6 months ago

exdx commented 6 months ago

The cargo feature flag workspace-inheritance stabilized post Rust v1.64.0 and is no longer required.

This would remove warnings when compiling the marginfi programs with anchor.

Warnings warning: /home/ubuntu/marginfi-v2/programs/marginfi/Cargo.toml: the cargo feature `workspace-inheritance` has been stabilized in the 1.64 release and is no longer necessary to be listed in the manifest See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance for more information about using this feature. warning: /home/ubuntu/marginfi-v2/observability/indexer/Cargo.toml: the cargo feature `workspace-inheritance` has been stabilized in the 1.64 release and is no longer necessary to be listed in the manifest See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance for more information about using this feature. warning: /home/ubuntu/marginfi-v2/programs/liquidity-incentive-program/Cargo.toml: the cargo feature `workspace-inheritance` has been stabilized in the 1.64 release and is no longer necessary to be listed in the manifest See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance for more information about using this feature. warning: /home/ubuntu/marginfi-v2/test-utils/Cargo.toml: the cargo feature `workspace-inheritance` has been stabilized in the 1.64 release and is no longer necessary to be listed in the manifest See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance for more information about using this feature. warning: /home/ubuntu/marginfi-v2/clients/rust/marginfi-cli/Cargo.toml: the cargo feature `workspace-inheritance` has been stabilized in the 1.64 release and is no longer necessary to be listed in the manifest See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance for more information about using this feature. warning: /home/ubuntu/marginfi-v2/tools/llama-snapshot-tool/Cargo.toml: the cargo feature `workspace-inheritance` has been stabilized in the 1.64 release and is no longer necessary to be listed in the manifest See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance for more information about using this feature.
exdx commented 6 months ago

I see we use Rust v1.66 in CI -- if we haven't updated we probably should not merge this. Closing for now.