search

mrh0 / buildersaddition

Builders Addition Minecraft Forge Mod by MRH0
MIT License
6 stars 12 forks source link

Water Dupe with the Cupboard #16

Closed WenXin20 closed 3 years ago

WenXin20 commented 3 years ago

Minecraft v1.16.4

If a Cupboard is placed in water that is only one block deep, the top half will still become waterlogged. Breaking the cupboard also deletes the water source instead of leaving it behind. Some blocks are also missing waterlogging, which would be nice to see.

Another couple of things I've noticed is that the Iron Rod can be given the tag #forge:rods/iron, for compat with other mods that use it, such as the Ultimate Car mod or Silent Gear. Also, a lot of the blocks are too large when placed in an item frame.

mrh0 commented 3 years ago

The Cupboard thing I'm aware of, I've tried to fix it but will probably just remove waterlogging on it. The Iron Rod is already tagged #forge:rods/iron. I'll take a look at the Item frame thing.

WenXin20 commented 3 years ago

Thanks! From taking a quick look, it looks like it could be happening because the getStateForPlacement is setting the state to be waterlogged instead of checking if the top half is in water or air, but I'm not entirely sure. Here's a block that I previously added waterlogging for that also has two parts.

mrh0 commented 3 years ago

Alright thanks, I'll take a look when I've got time!

mrh0 commented 3 years ago

Fixed in 20201220b.