mrh0 / buildersaddition

Builders Addition Minecraft Forge Mod by MRH0
MIT License
6 stars 12 forks source link

[ Suggestion ] 1.18.2 - Changing the constructor regarding the String name #75

Closed Xelbayria closed 10 months ago

Xelbayria commented 11 months ago

Hello,

I've looked at the difference between 1.18.2 and 1.19.2. It turned out that 1.19.2 doesn't have .setRegistryName(name); in its constructor via BaseBlock.class

I had an issue with .setRegistryName(name) because of the String Concatenation which give the wrong ID for the block in the module of BuildersAddition (BCA) for EveryCompat.

I am trying to port the module from 1.19.2 to 1.18.2, so it can support BCA

is it possible to make a small change to remove .setRegistryName(name) and use a similar setup in 1.19.2 for 1.18.2 where it will concatenate the string for the block's ID?

I look forward to hearing from you about this.