mrh0 / createaddition

Create Crafts & Additions, Addon to the Create mod by the Create Team.
Other
84 stars 112 forks source link

Compatibility Broken with CraftTweaker and KubeJs #683

Closed TopStiGear closed 11 months ago

TopStiGear commented 1 year ago

Describe the bug Unable to create recipes using CreateAddition machines. CraftTweaker reads all existing RecipeTypes as <recipetype:null> and sends back the error Unknown RecipeType: <recipetype:createadditions:rolling>

To Reproduce Steps to reproduce the behavior: Run Command /crafttweaker recipes hand with a CreateAdditions machine craftable item for logs to read back <recipetype:null>. Run Command /ct dump recipetype to have no CreateAddition RecipeTypes return in logs.

Additional context

This is not just a CraftTweaker issue. It is a base code issue of the CreateAddition Mod itselt by not labelling RecipeType's correctly. All it would take to fix is to change the RecipeType from Null to the correct type, Rolling, Charging or Liquid_Burning. KubeJs is not a fix its a cop-out for coding a mod incorrectly. Update: It also does not work with KubeJs as they also rely on correct RecipeType labelling.

mrh0 commented 11 months ago

fixed in v1.2.0.