mrh0 / createaddition

Create Crafts & Additions, Addon to the Create mod by the Create Team.
Other
84 stars 111 forks source link

Found the reason for old crash in liquid blaze burner code #789

Open pollyzoid opened 5 months ago

pollyzoid commented 5 months ago

The reason for an old crash (#366) is likely due to a missing return statement in liquid blaze burner's burningTick. Means the if statement supposed to prevent .get on an empty recipe cache is only run if remainingBurnTime < 1. Probably should be fixed and the try-catch workaround removed.

https://github.com/mrh0/createaddition/blob/4cf7c58c8168850d31320ee4eef635196d4462a9/src/main/java/com/mrh0/createaddition/blocks/liquid_blaze_burner/LiquidBlazeBurnerBlockEntity.java#L144

I just noticed this while browsing (props for the comment next to the workaround) and figured I should mention it.