Closed adenvt closed 1 month ago
Hi @adenvt,
Thank you for your contribution 🎉
Personally I don't find it is maintainable to have a manual .d.ts
file.
I think that this places the highest burden on maintainers and provides the least value/assurances.
So I don't think we can accept this even if I appreciate your effort.
However I would consider a change that adds JSDoc type annotations.
Benefits of JSDOc annotations:
.d.ts
files can be generated from themStylelint for example uses such a setup : https://github.com/stylelint/stylelint
@romainmenke Thank for reviewing.
I'm update it, and follow your approach to use JSDoc and generate .d.ts
from it. I did:
npm run build-types
to generate .d.ts
lib/index.js
to has more strict type.script/clean.js
to remove types/*
before build.gitignore
Add type definition for typescript user