search

mrhenry / polyfill-library

MIT License
7 stars 1 forks source link

Fixes iterator helpers when interacting with other polyfills #80

Closed mhassan1 closed 2 weeks ago

mhassan1 commented 1 month ago

This PR fixes iterator helpers when loaded alongside other polyfills (e.g. String.prototype.@@iterator). It is a follow-up to https://github.com/mrhenry/polyfill-library/pull/76.

romainmenke commented 1 month ago

IE is still failing, but might also be a browserstack issue: https://github.com/mrhenry/polyfill-library/actions/runs/11454689367/job/31934817539 I've noticed that IE has more and more intermittent issues on browserstack.

mhassan1 commented 1 month ago

IE is still failing, but might also be a browserstack issue: https://github.com/mrhenry/polyfill-library/actions/runs/11454689367/job/31934817539 I've noticed that IE has more and more intermittent issues on browserstack.

I can replicate that issue locally. When I look in BrowserStack, I see Browser could not be launched for the session. Here are some docs about that: https://www.browserstack.com/docs/automate/selenium/error-codes/browserstack-failed-to-start-browser. Maybe we should open a support ticket.

Any comments on this PR?

mhassan1 commented 3 weeks ago

@romainmenke Please take a look, if you have some time.

romainmenke commented 2 weeks ago

Haven't had much time :/ I will review this in the coming days