search

mrhooray / crc-rs

Rust implementation of CRC(16, 32, 64) with support of various standards
Apache License 2.0
187 stars 49 forks source link

expose lookup tables #117

Closed BKSalman closed 5 months ago

BKSalman commented 5 months ago

resolves #112

any comments?

akhilles commented 5 months ago

LGTM. The new Implementation API was just merged (https://github.com/mrhooray/crc-rs/pull/115). Do you mind rebasing? Sorry for the churn.

BKSalman commented 5 months ago

Will do, np

BKSalman commented 5 months ago

@akhilles should I make it like this?

    pub const fn table(&self) -> <Table<1> as Implementation>::Data<u8> {
        self.data
    }
BKSalman commented 5 months ago

I will be off for holidays, and won't be able to commit for a couple of days, I will try to tho since it's just a small change

BKSalman commented 5 months ago

Thank you :)