search

mrhooray / crc-rs

Rust implementation of CRC(16, 32, 64) with support of various standards
Apache License 2.0
187 stars 49 forks source link

fix benchmarks #72

Open fkohlgrueber opened 2 years ago

fkohlgrueber commented 2 years ago

Hi,

I did a couple of straight-forward changes such that cargo bench works again. I also fixed the deprecation warnings in the benchmarks ~and changed the rust edition to 2021~.

Let me know if you want anything changed.

fkohlgrueber commented 2 years ago

@akhilles @mrhooray any feedback on this?

akhilles commented 2 years ago

I think this bumps the MSRV right? So, might require a major version release.

fkohlgrueber commented 2 years ago

Ah right, didn't think about that. Using edition 2021 would bump MSRV from 1.46 to 1.56. I propose to keep the edition to 2018 for now and just integrate the benchmark fixes. Fixing the benchmarks doesn't require increasing MSRV.

Sounds good?

akhilles commented 2 years ago

https://github.com/plotters-rs/plotters/issues/398 is causing tests to fail, maybe pin the version to v0.3.1?