search

mrhut10 / futuresFineFurniture

futuresFineFurniture ecom website
https://futuresfinefurnitureandbedding.com
3 stars 1 forks source link

double discount problem found in some cases #60

Closed mrhut10 closed 5 years ago

mrhut10 commented 5 years ago

just found an error in some logic that will apply a discount twice on checkout. potencially could cost company a lot if someone finds the few products that are affected by this bug.

I've already written fixed i think locally however need to just test the code before pushing live.

mrhut10 commented 5 years ago

all my tests i ran work on laptop now, just pushing to staging branch and will test it on netlify hosting

mrhut10 commented 5 years ago

lol ofcause introducted a small no length property of undefined error, but fixed that too now

mrhut10 commented 5 years ago

ok, just pushed to production.

was a fairly heavy rewrite of the snipcart logic.

I will now need to do some test sales of products to confirm sale processes

mrhut10 commented 5 years ago

anyway i'll reopen if have problems