search

mrhut10 / todaysCuriosity

a set of single_image_processing effects inspired by the art work by Kensuke Koike. See live demo on
https://todayscuriosity.netlify.com/
5 stars 9 forks source link

Add image from URL #35

Closed AraanBranco closed 6 years ago

AraanBranco commented 6 years ago

Add feature for load image from URL, issue #34

ghost commented 6 years ago

@AraanBranco Thanks a bunch for the PR. I'm a little busy atm, but I should be able to review this soon.

mrhut10 commented 6 years ago

thank you @AraanBranco

just had a very quick look just had a concern that we aren't handling not found errors or potentially timeouts if the server doesn't exist. are you able to handle these cases and add the error to your error display method on the field.

Regards from me :)

AraanBranco commented 6 years ago

I add one console for debbug error and alert user for error, I believe this will solve.