search

mrice / license-check

Make sure your Maven dependencies have declared, recognized open source licenses
http://michaelrice.com
MIT License
41 stars 21 forks source link

multi module project fix and LGPL detection fix #16

Open subes opened 8 years ago

subes commented 8 years ago

This change is Reviewable

mrice commented 8 years ago

@subes

THANKS SO MUCH FOR THE PULL REQUEST!!! Especially if the LGPL is getting flagged as GPL in some instances -- definitely don't want that.

My only hesitation with your PR is that I think your IDE reformatted a lot of the code (maybe just indents) and so I can't lock in on the exact change you made...

Any way you can submit a small commit or even just comment here on the change you made (I assume it was just the regex file)??? I'm happy to do the grunt work on it since it should be easy...

Again, I'm so sorry it took me 12 days to get back to you. Time is always an issue for me, but I really do respect the time you put into the PR even though it doesn't seem like it when it takes so long to respond. Thanks!

subes commented 6 years ago

I modified the java file whitespaces so that the changes are more easily visible.

Github seems to be too stupid to diff the text file, so here is a screenshot that shows what has actually changed. The change is simple by just moving the lgpl checks before gpl checks, because the gpl regex would watch lgpl too...

textdiff