search

mrice / license-check

Make sure your Maven dependencies have declared, recognized open source licenses
http://michaelrice.com
MIT License
41 stars 21 forks source link

Perhaps implement this plugin as a Maven Enforcer Rule? #25

Open volkertb opened 7 years ago

volkertb commented 7 years ago

First of all, thanks for this project! I was frankly surprised to see that Maven didn't already facilitate the filtering of dependencies by license type. This is an important feature for many organizations! Keep up the good work.

My suggestion is this: wouldn't it be better to integrate this with the existing Maven Enforcer Plugin by making this plugin an Enforcer Rule? That seems to be the established standard "mechanism" within the Maven ecosystem for filtering dependencies according to certain criteria.

I imagine that at first this plugin would then initially continue to exist as a separate Enforcer rule plugin, but perhaps the upstream Maven developers would then eventually be open to adding it to the standard set of Enforcer rules.

I've dabbled a little bit with Maven plugin development myself, so if you are open to this idea, perhaps I could try to help you out in accomplishing this.

But perhaps you had already considered this approach and already decided against it for good reasons?

Anyway, thanks for considering this suggestion.

mrice commented 7 years ago

Thanks very much for the comment! I have to confess that I first wrote license-check in a hotel room one night on a trip, so I really didn't give a ton of thought to the right approach. And I was completely new to plugin development at the time too so I think I made a lot of mistakes!!

These days I've got a lot of other things going on, so I'll definitely leave this issue open and hope that you or someone takes it up as a new generation of the plugin!!!

volkertb commented 7 years ago

Cool! No promises from my part, due to the same reason as yours: so many fun projects and things to do, but so little time... :smile: Perhaps I'll get around to having a go at this some time. Are you open to receiving pull requests, or would you prefer someone else forking it and taking over the entire project at this point?

mrice commented 7 years ago

Well if you're going to make a fundamental architectural change with the enforcer stuff, seems like it makes sense to just do a fork. And I'm not the best steward of the project anymore anyway!