search

mrichard / generator-marionette

Yeoman marionette generator a la AMD
329 stars 72 forks source link

Fixes the templates and grunt-contrib-handlebars so compilation works. #11

Closed juliomenendez closed 11 years ago

juliomenendez commented 11 years ago

The templates weren't getting compiled at all with grunt build. The path to them was wrong.

Once that was fixed them Backbone wasn't able to find the templates because of the way the template property was set.

mrichard commented 11 years ago

So it looks like this marionette handlerbars shim isn't needed? https://github.com/asciidisco/Backbone.Marionette.Handlebars

Marionette seems to execute the template property as a function if it is one. Passing data as the param.

juliomenendez commented 11 years ago

It seems so. I guess you can remove it.

mrichard commented 11 years ago

Yeah Marionette 0.9 didn't do this. Nice I will remove and merge this shortly.

mrichard commented 11 years ago

Marionette.Handlebars plugin also removed

rrichter commented 11 years ago

Hi, thanks for fixing this. I have the feeling that theres a typo in the Gruntfile.js

'.tmp/scripts/templates.js': ['<%= yeoman.app %>templates/**/*.hbs']

shouldn't it be:

'.tmp/scripts/templates.js': ['<%= yeoman.app %>/templates/**/*.hbs']

?