search

mrichard / generator-marionette

Yeoman marionette generator a la AMD
329 stars 72 forks source link

Updated all libraries and dependencies to the latest stable releases for both Bower and Node Modules. #42

Open vairav opened 10 years ago

vairav commented 10 years ago

Since most of the libraries and dependencies were updated, I have updated them to the latest stable releases.

nigel-dev commented 10 years ago

I think this will cause an issue, as the way requirejs is handled has changed (They dropped support for the data blocks).

vairav commented 10 years ago

It would be of great help if you can let me know on what would be the issue as I'm not able to think of any :)

nigel-dev commented 10 years ago

I sort of cheated, and copied the libs you updated to a project that I already had completed (bower and package json). When I went to run it, I was presented with an error from usemin dealing with the data blocks in index.html. Here is a link to what I found from usemin: https://github.com/yeoman/grunt-usemin/issues/112

vairav commented 10 years ago

I'm still working on it nbazzeghin. I will update once when I find a proper fix for it.

mrichard commented 10 years ago

Hi, Is this ready to merge? I am about to dive in and update all libs. Thanks!

nigel-dev commented 10 years ago

I think this updates the libs, but I am not sure if the usermin thing has been addressed.

dannytranlx commented 10 years ago

Any news on this issue?

nichdiekuh commented 10 years ago

I've fixed the build process in my fork of this generator. In case anyone is still interested in a fix, it might be worth looking at the build process here: https://github.com/nichdiekuh/generator-marionette2