search

mrichards42 / xword

Cross-platform crossword solving
https://mrichards42.github.io/xword/
GNU General Public License v3.0
42 stars 13 forks source link

Always draw annotation square text #202

Closed mrichards42 closed 1 year ago

mrichards42 commented 1 year ago

This failed when printing a blank grid (which sets neither DRAW_USER_TEXT nor DRAW_SOLUTION flags).

Bug reported in an email this morning.

@jpd236 since I haven't done much (anything?) with annotation squares, mind giving this a quick peek to see I missed anything obvious? I think this is a pretty simple fix, but you never know.

mrichards42 commented 1 year ago

The only thing I'm not certain about is whether it's guaranteed that a "clue" type square is guaranteed to have the user text populated, as opposed to the solution text. I think in practice both are typically populated, so this works. That said, if there was a puzzle out there which only populated the solution text, I think it would have already been broken since the symbol wouldn't have been drawn in the grid view?

Good question -- all the files I've seen in the wile have both populated like you said, and glancing through the crosswordnexus solver code I think it draws solve-state not solution, so same behavior as XWord.

Thanks for taking a look!