Improve handling of puzzles without solutions.

mrichards42 / xword

Cross-platform crossword solving

https://mrichards42.github.io/xword/

GNU General Public License v3.0

42 stars 13 forks source link

Improve handling of puzzles without solutions. #210

Closed jpd236 closed 1 year ago

jpd236 commented 1 year ago

Support IPUZ/JPZ files without solutions, leveraging the existing PUZ grid flag. For IPUZ files, we can look at whether the solution grid is present. For JPZ files, we look at whether any letter squares have non-empty solutions.
Respect the "no solution" grid flag when evaluating the completion status. This prevents us from thinking that the grid is correctly filled when it is fully empty.

mrichards42 commented 1 year ago

Is a fully blank solution grid the standard workaround for jpz files with no solution? If so could we also update the jpz saving code to handle FLAG_NO_SOLUTION? It looks like it currently bails https://github.com/mrichards42/xword/blob/ce1629706756a9d66e5abfe2ae34b672e5875dcf/puz/formats/jpz/save_jpz.cpp#L64-L65

jpd236 commented 1 year ago

Thanks - good catch as I forgot to test the save path.

I'm not sure about "standard", but based on what Crossword Compiler outputs when you ask it not to include the solution, it seems like there are a few differences: blank solution grid, omitting check/reveal options from the supported actions, and having the completion message show up regardless of correctness. So I've updated the save path to do exactly this.

mrichards42 commented 1 year ago

Thanks for the crossword compiler investigation, this looks great