search

mricon / b4

Tool to help with email-based patch workflows
GNU General Public License v2.0
59 stars 20 forks source link

Support Based-on: #15

Open akihikodaki opened 8 months ago

akihikodaki commented 8 months ago

Hi,

I'm trying out b4 since I have been recently contributing to Linux and am currently using it for QEMU development too. It works well for QEMU as well.

One thing I miss though is the support for Based-on:, which is a tag to denote the dependency series. https://qemu.readthedocs.io/en/v8.1.0/devel/submitting-a-patch.html#base-patches-against-current-git-master

It's somewhat specific to QEMU so it may not be in the main scope of this tool, but let me open an issue just for record.

marcosps commented 6 months ago

@akihikodaki the current version of b4 adds a base-commit in the cover-letter, as you can see in this patchset that I sent some time ago.

Maybe it's just a question of wording in this case? @mricon do you think that Based-on is better than base-commit, or can it be configured?

akihikodaki commented 6 months ago

@marcosps @mricon Based-on: uses Message-Id, so you can easily look up the base series on lore.kernel.org, for example. Is it possible with base-commit?

marcosps commented 6 months ago

@marcosps @mricon Based-on: uses Message-Id, so you can easily look up the base series on lore.kernel.org, for example. Is it possible with base-commit?

I believe that base-commit is just the commit hash =/