search

mricon / b4

Tool to help with email-based patch workflows
GNU General Public License v2.0
59 stars 20 forks source link

inconsistent behaviour of `b4 am` #4

Open zimoun opened 1 year ago

zimoun commented 1 year ago

Hi, Thanks for your tool! I am using it for the project GNU Guix. Especially with the Emacs package piem by Kyle (@kyleam). In addition, Kyle maintains an unofficial public-inbox. Here my configuration:

[b4]
        midmask = https://yhetil.org/guix/%s
        linkmask = https://yhetil.org/guix/%s
        attestation-policy = off
        cache-exprire = 60

Considering this relative complex thread, depending on the message ID, the extraction of the patches fails or passes.

For instance, it fails from this one:

$ b4 am 87357fjyuc.fsf_-_@gmail.com
Looking up https://yhetil.org/guix/87357fjyuc.fsf_-_%40gmail.com
Grabbing thread from yhetil.org/guix/87357fjyuc.fsf_-_%40gmail.com/t.mbox.gz
Analyzing 27 messages in the thread
Assuming new revision: v10 ([bug#60788] [PATCH v2] services: vnstat: Use least-authority-wrapper.)
Will use the latest revision: v10
You can pick other revisions using the -vN flag
---
  [PATCH v10 1/3] services: Add vnstat-service-type.
  ERROR: missing [2/3]!
  ERROR: missing [3/3]!
---
Total patches: 1
---
WARNING: Thread incomplete!
 Link: https://yhetil.org/guix/4e67d41880a44306c5b5d0a39c776083c180cd15.1683245610.git.mirai@makinata.eu
 Base: using specified base-commit 3c91f4ca490a7ac56dc0aebbca9c4bf4df201877
       git checkout -b v10_20230505_mirai_makinata_eu 3c91f4ca490a7ac56dc0aebbca9c4bf4df201877
       git am ./v10_20230505_mirai_services_add_vnstat_service_type.mbx

or fails differently this other one:

$ b4 am f3b90db7de20b4deab630a53c5c970fa776b0e7a.1673730322.git.mirai@makinata.eu
Looking up https://yhetil.org/guix/f3b90db7de20b4deab630a53c5c970fa776b0e7a.1673730322.git.mirai%40makinata.eu
Grabbing thread from yhetil.org/guix/f3b90db7de20b4deab630a53c5c970fa776b0e7a.1673730322.git.mirai%40makinata.eu/t.mbox.gz
Analyzing 27 messages in the thread
Assuming new revision: v4 ([bug#60788] [PATCH v2] services: vnstat: Use least-authority-wrapper.)
Assuming new revision: v10 ([bug#60788] [PATCH v4] services: Add vnstat-service-type.)
Assuming new revision: v10 ([bug#60788] [PATCH v2] services: Add vnstat-service-type.)
Will use the latest revision: v10
You can pick other revisions using the -vN flag
---
  [PATCH v10] services: Add vnstat-service-type.
  [PATCH v10 2/3] services: inetd: Export accessors.
  ERROR: missing [3/3]!
---
Total patches: 2
---
WARNING: Thread incomplete!
 Link: https://yhetil.org/guix/beb55c678fea6c72c593dad446592ada135ee8c4.1674002048.git.mirai@makinata.eu
 Base: not specified
       git am ./v10_20230118_mirai_services_add_vnstat_service_type.mbx

Last, it passes for that one:

$ b4 am 87cz4ftq5z.fsf@gmail.com
Looking up https://yhetil.org/guix/87cz4ftq5z.fsf%40gmail.com
Grabbing thread from yhetil.org/guix/87cz4ftq5z.fsf%40gmail.com/t.mbox.gz
Analyzing 27 messages in the thread
Assuming new revision: v7 ([bug#60788] [PATCH v2] services: vnstat: Use least-authority-wrapper.)
Will use the latest revision: v10
You can pick other revisions using the -vN flag
---
  [PATCH v10 1/3] services: Add vnstat-service-type.
  [PATCH v10 2/3] services: inetd: Export accessors.
  [PATCH v10 3/3] tests: Add vnstat tests.
---
Total patches: 3
---
 Link: https://yhetil.org/guix/4e67d41880a44306c5b5d0a39c776083c180cd15.1683245610.git.mirai@makinata.eu
 Base: using specified base-commit 3c91f4ca490a7ac56dc0aebbca9c4bf4df201877
       git checkout -b v10_20230505_mirai_makinata_eu 3c91f4ca490a7ac56dc0aebbca9c4bf4df201877
       git am ./v10_20230505_mirai_services_add_vnstat_service_type.mbx

Let me know if details are missing.

Cheers, simon