mricon / b4

Tool to help with email-based patch workflows
GNU General Public License v2.0
70 stars 24 forks source link

Reported-by tag gets ignored/corrupted #50

Open floatious opened 2 weeks ago

floatious commented 2 weeks ago

$ b4 --version 0.14.2

$ b4 shazam -sl "20241023105540.1070012-2-cassel@kernel.org" Look at Reported-by tag. I it will look like this: "Reported-by:"

Compare with: https://lore.kernel.org/linux-ide/20241023105540.1070012-2-cassel@kernel.org/ where the Reported-by tag looks like this: Reported-by: Lai, Yi yi1.lai@linux.intel.com

Doing a "git log": $ git log v6.9..v6.12-rc4 | grep Reported-by | grep ,

Shows that not all Reported-tags have quotes around the a name that contains ",".

Perhaps quoting the names that contains "," is the right thing to do, but then perhaps b4 could automatically add quotes to such a name?

blmaier commented 2 weeks ago

I was able to recreate this as well. RFC 2822 for email does require display names to be quoted when they have commas, and b4 uses Python's email parser which parses to the empty string.

I sent a series to the mailing list to try and fix it https://lore.kernel.org/tools/20241027-trailer-special-chars-v1-0-1bd180dba425@gmail.com/T/#t It doesn't attempt to parse it into an email, but at least preserves the trailer so it isn't lost.