search

mridoni / gixsql

GixSQL is an ESQL preprocessor and a series of runtime libraries to enable GnuCOBOL to access PostgreSQL, ODBC, MySQL, Oracle and SQLite databases.
GNU General Public License v3.0
16 stars 8 forks source link

re-align COBOL_TYPE_UNSIGNED_BINARY code to use `switch` #136

Closed GitMensch closed 1 year ago

GitMensch commented 1 year ago

I'd have sent in a PR, but I'm not sure about the not-yet-checked-in changes with the dynamic memory changing the related code, so here's the suggestion to change those lines: https://github.com/mridoni/gixsql/blob/debeeeabb9e740f89a03e325e69553ec5e47149f/runtime/libgixsql/SqlVar.cpp#L281-L316 (and similar) to use switch (this->length) instead of nested if/else.

I may send in a PR for that when wanted, too.

mridoni commented 1 year ago

This is undergoing a massive overhaul due to #124, so a PR would be probably wasted, but I am scheduling this for v1.0.20