search

mridoni / gixsql

GixSQL is an ESQL preprocessor and a series of runtime libraries to enable GnuCOBOL to access PostgreSQL, ODBC, MySQL, Oracle and SQLite databases.
GNU General Public License v3.0
16 stars 8 forks source link

reduce temporary object creation for pgsql connect #85

Closed GitMensch closed 1 year ago

GitMensch commented 2 years ago

Feel free to ignore this PR, I've just stumbled over this when stepping through the code, getting into the std::string connector two times instead of once and thought "that would be easier to debug when I can just see those values directly instead of stepping into these functions".

Performance-wise it will obviously make no difference, and likely the other drivers are similar.

BTW: I've failed to get the connection string be printed from the connection info, what is wrong in the following line?`

|(gdb) p conn_info.toConnectionString(false,"")
Cannot resolve method IDataSourceInfo::toConnectionString to any overloaded instance

Side note: maybe drop the boolean parameter and instead only checking for the std:string to be empty (currently both is done)?

GitMensch commented 2 years ago

There were changes in 081674b3c03e1b97b0a2edf854a152d765331bee but I think that's still open (and we now have some commented lines in, that may should be removed).

No priority at all, just something that has been seen during debugging.

GitMensch commented 2 years ago

no conflicts so I guess that minor issue is likely still open

GitMensch commented 1 year ago

ping @mridoni - I guess this is still not obsolete with the "C++ization" coming.

mridoni commented 1 year ago

ping @mridoni - I guess this is still not obsolete with the "C++ization" coming.

Yes, it will be closed with v1.0.20

mridoni commented 1 year ago

Closing this since it has become obsolete (still thanks again!)