mriedmann / humhub-docker

Alpine-based PHP-FPM and NGINX HumHub docker-container
MIT License
95 stars 79 forks source link

allow nginx configuration extension through /etc/nginx/conf.d/*.conf #285

Closed jvies closed 9 months ago

jvies commented 1 year ago

OK... I think I pushed too quickly :)

I'll do some other tests

jvies commented 1 year ago

My local test runs fine. As far as I understand, the test that fails checks a button with "Sign in" is present. On my local deployment, this button does not exist, as the page displayed is the installer wizard. Any idea why my local deployment is different on from on the test deployment ?

mriedmann commented 1 year ago

In theory the test step should start the auto-installer. Maybe you haven't called that locally? Also it could be that it is simply broken.

jvies commented 1 year ago

I built the docker image locally (using docker build . --tag humhub:master --build-arg HUMHUB_VERSION=1.11.4 It starts, but I can't find any button with "Sign in". The only available buttons are:

            <!-- Footer -->
                            <div class="modal-footer">
                    <button data-modal-cancel data-modal-close class="btn btn-default"></button><button data-modal-confirm data-modal-close class="btn btn-primary"></button>                </div>
                        </div>
</div>   

This happens on master, as on my own branch. Any idea why ?

mriedmann commented 9 months ago

closed/reopened to run the checks again => There is no apparent reason this is failing. I am a bit puzzled tbh.

mriedmann commented 9 months ago

ok, this makes more sense now ... we most likely have to clear out the /etc/nginx/conf.d directory in the nginx base-image. Currently, we are ignoring those files but with your change this will mess up our config.

@jvies Can you try to add a "RUN rm -rf /etc/nginx/conf.d" before the copy step in on the nginx image in the Dockerfile? This should fix the pipeline. Will merge it if it runs green.

mriedmann commented 9 months ago

I might made an error sorry ... deleting the dir might not be what we wanted ... rather deleting the content of it RUN rm /etc/nginx/conf.d/*

sorry

jvies commented 9 months ago

seems better thx ! I rebase and push again.