mrikirill / SynologyDDNSCloudflareMultidomain

Synology DDNS Cloudflare service provider with multidomains and subdomains
https://mrikirill.github.io/SynologyDDNSCloudflareMultidomain/
MIT License
450 stars 64 forks source link

Unknown error while update IP adress #18

Closed havastamas closed 3 years ago

havastamas commented 3 years ago

I have set up the lastest version of SynologyDDNSCloudflareMultidomain on my Synology, but when i configure the DDNS, the DSM reports unknow error.

I have tired the debug command, and it gives the following error:

Catchable fatal error: Argument 2 passed to updateCFDDNS::setRecord() must be an instance of string, null given, called in /usr/syno/bin/ddns/cloudflare.php on line 85 and defined in /usr/syno/bin/ddns/cloudflare.php on line 226

jkrasinger commented 3 years ago

Have installed the latest Version on My Synology Router. After setting up on my router got same error Message as @havastamas

sdhawade commented 3 years ago

Its a type hinting compatibility issue with PHP, you can edit line 226 as follows to get it to work original : function setRecord($arHostData, string $ip, $type) edit to : function setRecord($arHostData, $ip, $type)

jkrasinger commented 3 years ago

Thanks @sdhawade , now it's working.

IGProd commented 3 years ago

hi how much of record support script on synology dsm7 when i enter more than 5 subodmaine i got failed report with missed caracteres in the last record that i entred

for example www.domaine.com---test.domaine.com---test2.domaine.com---test. in DDNS server Cloudflare. The reported reason is [Incorrect hostname format.].

IGProd commented 3 years ago

hi how much of record support script on synology dsm7 when i enter more than 5 subodmaine i got failed report with missed caracteres in the last record that i entred

for example www.domaine.com---test.domaine.com---test2.domaine.com---test. in DDNS server Cloudflare. The reported reason is [Incorrect hostname format.].

I did not see the issue above, thank you

https://github.com/mrikirill/SynologyDDNSCloudflareMultidomain/issues/17