search

mrirecon / bart

BART: Toolbox for Computational Magnetic Resonance Imaging
https://mrirecon.github.io/bart/
BSD 3-Clause "New" or "Revised" License
291 stars 161 forks source link

fix basis pursuit pics when using a sampling pattern #285

Closed jtamir closed 2 years ago

jtamir commented 2 years ago

@uecker not sure if you would prefer to add conf.bpsense to the if case or just re-initialize even if loop flags is zero.

TODO before accepting the PR: figure out why the bpsense tests didn't fail.

jtamir commented 2 years ago

The issue with the previous code/test is that the initialization only matters for bpsense when the sampling pattern is not all-ones. The new test uses a sampling pattern and checks the data consistency error instead of reconstruction error

jtamir commented 2 years ago

I'm getting failed tests that as far as I can tell are unrelated, and do not fail on my machine. Any ideas?