mriscoc / Ender3V2S1

This is optimized firmware for Ender3 V2/S1 3D printers.
Other
2.65k stars 360 forks source link

[BUG] Source code won't compile Klackender UBL, "probeTest" is undefined #1103

Closed dB-v closed 1 year ago

dB-v commented 1 year ago

Did you test with a precompiled firmware?

Yes, and the problem still exists.

Bug Description

Edited both Configuration.h and Configuration_adv.h using klackender documentation (https://github.com/kevinakasam/KlackEnder-Probe). Getting errors in compiling

Bug Timeline

September release - 20230904

Expected behavior

Expected it to compile since I've tried both BLT and MM configurations, and they both compiled with no issue. I've edited the MM configuration and commented out the manual mesh lines, while enabling/editing the required lines for the klackender. There were no errors found in the configuration.h and configuration_adv.h, only during compiling errors were found in dwin.cpp and menus.h

Actual behavior

platformio run --silent -e STM32F103RE_creality In file included from Marlin\src\lcd\e3v2\proui\dwin.cpp:98: Marlin\src\lcd\e3v2\proui\dwin.cpp: In function 'void drawProbeSetMenu()': Marlin\src\lcd\e3v2\proui\dwin.cpp:2880:63: error: 'probeTest' was not declared in this scope Marlin\src\lcd\e3v2\proui\menus.h:52:59: note: in definition of macro 'MENU_ITEM' 52 | #define MENU_ITEM(I,L,V...) menuItemAdd(I, GET_TEXT_F(L), V) | ^ *** [.pio\build\STM32F103RE_creality\src\src\lcd\e3v2\proui\dwin.cpp.o] Error 1

Steps to Reproduce

Download source files, extract to a new folder. Edit the marlin configuration files based on klackender documentation (https://github.com/kevinakasam/KlackEnder-Probe) retain PROBING_MARGIN 10, 15 did not work for firmware

Version of Professional Firmware

Source files downloaded 9/24/2023

Printer model

Ender 3 V2

Electronics

4.2.2

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

None

Host Software

None

Additional information & file uploads

Klackender configuration files.zip

dB-v commented 1 year ago

fixed issue uncommented the Z_MIN_PROBE_REPEATABILITY_TEST in configuration.h and firmware now compiles without errors

github-actions[bot] commented 11 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.