Have Sound(beep) disabled for button clicks, but leave enabled when printing (with Gcode)

[classicrocker883]

When I disable sound, it disables it entirely.

I'd like it to just be disabled for button clicks - Menu navigation.

Is there a way to leave it enabled when printing, say for Gcode to produce?

[mriscoc]

It is possible to mute menu clicks by editing the enconder.cpp file and commenting out the content of Encoder_tick:

void Encoder_tick() {
  #if PIN_EXISTS(BEEPER)
    if (ui.sound_on) buzzer.click(10);
  #endif
}

[classicrocker883]

@mriscoc I commented out

Encoder_Tick();

on line 88 in encoder.cpp i didnt actually try commenting out

void Encoder_tick() {
  #if PIN_EXISTS(BEEPER)
    if (ui.sound_on) buzzer.click(10);
  #endif
}

i also found a bug

file: src/inc/Conditionals_Adv.h line: 1028

it should be

#ifndef LCD_SERIAL_PORT

originally it is #ifdef because the LCD serial port for ender3v2 and the voxelab aquila is defined as >> 3

the warning shows up when line 105 is commented out in Configuration.h

//#define NO_AUTO_ASSIGN_WARNING

[mriscoc]

The line:

  #ifdef LCD_SERIAL_PORT

Is correct, see: https://github.com/MarlinFirmware/Marlin/blob/5b68a3f79b845c4c125c43cfd0d506073da6007e/Marlin/src/inc/Conditionals_adv.h#L1049

The line:

#define NO_AUTO_ASSIGN_WARNING

Is there to avoid the warnings because LCD_SERIAL_PORT was defined automatically in Conditionals_Adv.h

[mriscoc]

This is not a firmware issue.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.