mriscoc / Ender3V2S1

This is optimized firmware for Ender3 V2/S1 3D printers.
Other
2.65k stars 360 forks source link

[BUG] Crash after removing SD card #894

Closed qwazwsx closed 1 year ago

qwazwsx commented 1 year ago

Did you test with a precompiled firmware?

Yes, and the problem still exists.

Bug Description

Version: Latest latest Release #20230312. Also confirmed on: #20221222

Firmware crashes (freezes and shows version popup) when selecting the "media" tab after printing and removing the SD card.

Bug Timeline

No response

Expected behavior

Expected Behavior When media is removed, the selected file should be reset to the top position ("Back").

Actual behavior

The selection indicator remains in the same position as the last selected file, even though there are no files present. Moving the scroll wheel selects the "Back" entry, and promptly freezes. After a few seconds, the firmware will restart, showing the version info.

Steps to Reproduce

Video showing the bug in action

Reproduction:

  1. Select an item in the Media menu. Either successfully print or cancel. You should be brought back to the main menu and your selection will be saved when you return to the media menu.
  2. Remove the SD card. Observe "Media Removed" M117 message
  3. Enter the Media menu. Observe that the selection from before is still 'selected' even though the menu is blank. See image above.
  4. Move the selector wheel, the selection should jump to the top ("Back") and the firmware will hang, before showing the version info popup and restarting.

Version of Professional Firmware

Professional Firmware v2.1.3 - Build Time 20230312 (Lastest GitHub release as of posting) Ender3V2-422-BLTUBL-MPC-20230312.bin

Printer model

Ender 3v2

Electronics

No response

Add-ons

BL Touch

Bed Leveling

UBL

Your Slicer

None

Host Software

None

Additional information & file uploads

No response

Majboor commented 1 year ago

xpected behavior should be that when the media is removed, the selection should be set to the top item "Back" in the media menu, and the application should not crash?

qwazwsx commented 1 year ago

Just tested on the latest Release #20230312 and can confirm that I am still experiencing this bug. I'll update the issue to reflect that.

@Majboor Yes. Opening the media menu after printing and removing the SD card causes a crash.

I've recorded a quick (and quite shaky, my apologies) demonstration video of the bug in effect on my Ender 3 v2. You can view that here: https://streamable.com/aafdwb

Here's what the bug looks like. Moving the scroll wheel at this point causes the printer to restart. image

I've added this information, and clarified a few things, in the original post.

classicrocker883 commented 1 year ago

do you have SD extender installed? try enable that setting in the configuration.h file.

mriscoc commented 1 year ago

This bug was fixed in the latest release.

qwazwsx commented 1 year ago

Cheers! Thanks for continuing to support this firmware

shayenss commented 1 year ago

Тази грешка беше коригирана в последната версия.

I have two Ender 3 S1 models and I uploaded version Ender3S1-F1-UBL-MPC-20230522B to both. I have the same problem with the SD card. It doesn't read my files and reboots, telling me the firmware version. Ask for assistance. ...The weird thing is that the first time, it read my SD card and after I took it out and put it back in, I got this error

mriscoc commented 1 year ago

I have the same problem with the SD card

Sorry, but it is not the same error, the bug listed here needs a specific procedure to trigger it. You can read from the OP post that he saw the items and printed them.

Your problem probably is your SD card.